-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part 2 robot simulator #309
Part 2 robot simulator #309
Conversation
This reverts commit 5f43378.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for working on this! Very excited to try it out; have not looked through all the files but in the meantime, here are some preliminary comments:
src/tabs/RobotSimulation/components/TabPanels/tabComponents/LastUpdated.tsx
Outdated
Show resolved
Hide resolved
src/tabs/RobotSimulation/components/TabPanels/UltrasonicSensorPanel.tsx
Outdated
Show resolved
Hide resolved
src/bundles/robot_simulation/controllers/ev3/ev3/default/types.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, sorry for the delayed review, thanks a lot for working on this! LGTM, though I just have a few minor comments; would kindly ask if you could reply to them.
Thanks and it looks really good too! 🤩
}; | ||
|
||
export const meshConfig: Ev3MeshConfig = { | ||
url: 'https://keen-longma-3c1be1.netlify.app/6_remove_wheels.gltf', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to eventually move this into a/the repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Sorry for the slow reply!
How do other modules host their static files? Is it inside the modules repo or in a separate repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far I think the only other module with static assets is unity academy, and we host the files in an S3 bucket on AWS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah alright. How do I go about to do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's take this over to Telegram.
height: 0.0575, | ||
length: 0.0575, | ||
}, | ||
url: 'https://keen-longma-3c1be1.netlify.app/6_wheel.gltf', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
|
||
// steps per tick | ||
for (let i = 0; i < this.config.stepsPerTick; i++) { | ||
const result = this.iterator.next(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this unused variable intentional?
Description
The EV3 robot simulator implementation is in PR. This looks like a big PR but about half of it is tests.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
There is 119 tests to test the main aspects of the robot simulation.
To try out the robot simulation. You can try out this snippet.
In this snippet, you will observe
Checklist: